Project

General

Profile

Bug #939

Post-style web service requests: Commented lines that happen to contain a known parameter cause failures

Added by Mick Van Fossen over 6 years ago. Updated almost 6 years ago.

Status:
New
Priority:
Low
Assignee:
Target version:
Start date:
01/31/2018
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Hi Mike: Looks like the doIrisProcessing routines by-and-large pay respect to #-commented lines such as # This is a comment.

However somewhere in the journey it must be parsing commented lines because if you enter a known query parameter in such comments it will confuse it for an entry meant for the user's request. For example "# This post file will test the format bug". (where format is a legit query param).

REPRO:
(1) Save the following to a file called foo.txt

# This is a test. The new format is really great!
# Bug 1234
#
nodata=404
CI BAR -- BHE 2015-07-01T00:00:00 2015-07-30T00:00:00

(2) Curl it to the federator service like so:
curl --data-binary @./foo.txt -s -D - https://service.iris.edu/irisws/fedcatalog/1/query

RESULT:
I'm seeing this error returned:

Error 400: doIrisProcessing - Invalid value for parameter: format

History

#1 Updated by Mike Stults about 6 years ago

  • Resolution set to Fixed

2018-05-14 832a893 - Added code to skip lines that start with #

#2 Updated by Mike Stults almost 6 years ago

  • Target version set to 2.4.4

2018-05-25 5a3b275 (Mike Stults): (HEAD > master, tag: v2.4.4, origin/master, origin/HEAD) - v2.4.4 for issues 939, 931, 927, 894, 841
uploaded webserviceshell/2.4.4/webserviceshell-2.4.4.jar 8545 KB

#3 Updated by Mick Van Fossen almost 6 years ago

Confirmed in 2.4.4. (I don't have permissions to set this bug as "Closed")

Also available in: Atom PDF